thread/hyprvoice
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mark task 17 complete - factory tests already exist

Browse Source
This commit is contained in:
leonardotrapani
2026-02-01 01:03:37 +01:00
parent a366d61558
commit ca3c03f507
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
progress.txt
+12
View File
@@ -147,3 +147,15 @@ Started: Sun Feb 1 12:22:47 AM CET 2026
- Empty model now uses provider's default transcription model - Empty model now uses provider's default transcription model
- Added tests for streaming model rejection and unknown model error - Added tests for streaming model rejection and unknown model error
- All tests passing, typecheck passes - All tests passing, typecheck passes
### Task 17: Write tests for transcriber factory
- Tests already exist in `internal/transcriber/transcriber_test.go` from Task 15
- Verified test coverage:
- `TestNewTranscriber/valid_openai_config` - creates OpenAIAdapter for openai
- `TestNewTranscriber/valid_groq-transcription_config` - creates OpenAIAdapter for groq
- `TestNewTranscriber/valid_elevenlabs_config_with_scribe_v1` - creates ElevenLabsAdapter
- `TestNewTranscriber/unsupported_provider` - returns error for unknown provider
- `TestNewTranscriber/unknown_model_returns_error` - returns error for unknown model
- `TestNewTranscriber/streaming_model_returns_error` - returns error for streaming model
- `go test ./internal/transcriber/...` passes
- Typecheck passes
tasks/prd.jsonc
+1 -1
View File
@@ -411,7 +411,7 @@
"Error cases handled", "Error cases handled",
"Typecheck passes" "Typecheck passes"
], ],
"passes": false "passes": true
}, },
// ============================================================================ // ============================================================================
// PHASE 4: LOCAL TRANSCRIPTION (whisper-cpp) // PHASE 4: LOCAL TRANSCRIPTION (whisper-cpp)