add effective language resolution for general.language support

This commit is contained in:
leonardotrapani
2026-02-01 13:16:24 +01:00
parent da8a1e5b0e
commit 7a3e590977
4 changed files with 75 additions and 2 deletions
+56
View File
@@ -1983,3 +1983,59 @@ func TestConfig_ToTranscriberConfig_Threads(t *testing.T) {
t.Errorf("Threads = %d, want 4", transcriberConfig.Threads)
}
}
func TestConfig_EffectiveLanguage(t *testing.T) {
t.Run("only general.language set", func(t *testing.T) {
config := &Config{
General: GeneralConfig{
Language: "es",
},
Transcription: TranscriptionConfig{
Provider: "openai",
Model: "whisper-1",
Language: "", // not set
},
}
transcriberConfig := config.ToTranscriberConfig()
if transcriberConfig.Language != "es" {
t.Errorf("Language = %q, want %q", transcriberConfig.Language, "es")
}
})
t.Run("transcription.language overrides general.language", func(t *testing.T) {
config := &Config{
General: GeneralConfig{
Language: "es",
},
Transcription: TranscriptionConfig{
Provider: "openai",
Model: "whisper-1",
Language: "en", // overrides general
},
}
transcriberConfig := config.ToTranscriberConfig()
if transcriberConfig.Language != "en" {
t.Errorf("Language = %q, want %q", transcriberConfig.Language, "en")
}
})
t.Run("neither set results in auto", func(t *testing.T) {
config := &Config{
General: GeneralConfig{
Language: "",
},
Transcription: TranscriptionConfig{
Provider: "openai",
Model: "whisper-1",
Language: "",
},
}
transcriberConfig := config.ToTranscriberConfig()
if transcriberConfig.Language != "" {
t.Errorf("Language = %q, want empty (auto)", transcriberConfig.Language)
}
})
}
+10 -1
View File
@@ -23,7 +23,7 @@ func (c *Config) ToRecordingConfig() recording.Config {
func (c *Config) ToTranscriberConfig() transcriber.Config {
config := transcriber.Config{
Provider: c.Transcription.Provider,
Language: c.Transcription.Language,
Language: c.resolveEffectiveLanguage(),
Model: c.Transcription.Model,
Keywords: c.Keywords,
Threads: c.Transcription.Threads,
@@ -34,6 +34,15 @@ func (c *Config) ToTranscriberConfig() transcriber.Config {
return config
}
// resolveEffectiveLanguage returns the effective language for transcription.
// transcription.language overrides general.language if set.
func (c *Config) resolveEffectiveLanguage() string {
if c.Transcription.Language != "" {
return c.Transcription.Language
}
return c.General.Language
}
// resolveAPIKeyForProvider returns the API key for a provider from multiple sources
func (c *Config) resolveAPIKeyForProvider(provider string) string {
providerName := provider