From 1f6fce6941920e91a0682357ebcf7912c32ec8cb Mon Sep 17 00:00:00 2001 From: leonardotrapani Date: Sun, 1 Feb 2026 13:17:39 +0100 Subject: [PATCH] move language to general section in config template --- internal/config/save.go | 9 ++++++++- progress.txt | 7 +++++++ tasks/prd.jsonc | 2 +- 3 files changed, 16 insertions(+), 2 deletions(-) diff --git a/internal/config/save.go b/internal/config/save.go index 5bfd2e5..39d5c78 100644 --- a/internal/config/save.go +++ b/internal/config/save.go @@ -25,6 +25,13 @@ func SaveDefaultConfig() error { # will be automatically migrated to the new [providers.X] format. Run 'hyprvoice configure' # to update your config file structure. +# ───────────────────────────────────────────────────────────────────────────── +# General Settings +# ───────────────────────────────────────────────────────────────────────────── + +[general] + language = "" # Language for transcription (ISO 639-1 code, e.g., en, es, de). Empty for auto-detect. + # Keywords help both transcription and LLM understand domain-specific terms # Add names, technical terms, or brand names that might be misheard keywords = [] @@ -69,9 +76,9 @@ keywords = [] [transcription] provider = "openai" # "openai", "groq-transcription", "groq-translation", "mistral-transcription", "elevenlabs", "whisper-cpp" - language = "" # Language code (empty = auto-detect, "en", "it", "es", "fr", etc.) model = "whisper-1" # Model: OpenAI="whisper-1", Groq="whisper-large-v3", Mistral="voxtral-mini-latest", ElevenLabs="scribe_v1" threads = 0 # CPU threads for local transcription (0 = auto: uses NumCPU-1) + # language = "" # Override general.language for this provider only # ───────────────────────────────────────────────────────────────────────────── # LLM Post-Processing (Recommended) diff --git a/progress.txt b/progress.txt index 8ec945d..7b78d9d 100644 --- a/progress.txt +++ b/progress.txt @@ -520,4 +520,11 @@ Started: Sun Feb 1 12:22:47 AM CET 2026 - Updated `ToTranscriberConfig()` to use `resolveEffectiveLanguage()` - Note: TOML loading already works automatically via struct tags (no load.go changes needed) - Added 3 tests in config_test.go: only general set, transcription overrides general, neither set (auto) +- All tests passing, typecheck passes + +### Task 49: Update config template to include general section +- Added `[general]` section at top of configTemplate in save.go +- Added `language = ""` with comment about ISO 639-1 codes and auto-detect +- Removed `language = ""` from `[transcription]` section +- Added commented `# language = ""` in transcription section with note about override - All tests passing, typecheck passes \ No newline at end of file diff --git a/tasks/prd.jsonc b/tasks/prd.jsonc index ac6f38a..7d0ec10 100644 --- a/tasks/prd.jsonc +++ b/tasks/prd.jsonc @@ -46,7 +46,7 @@ "Template shows language under [general] not [transcription]", "Typecheck passes" ], - "passes": false + "passes": true }, { "title": "Add SectionLanguage to TUI configure menu",